Kfi 270 #26784
Open
Kfi 270 #26784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Clohessy <[email protected]>
Signed-off-by: Jonathan Clohessy <[email protected]>
* Add onnxruntime_KLEIDIAI_SME_DISABLED as a cmake parameter. * In mlas_kleidiai.h set to false IsSMEAvailable when the parameter is set. * Fix bad parameter naming of onnxruntime_KLEIDIAI_DEBUG_LOGGING and onnxruntime_KLEIDIAI_KERNEL_LOGGING in cmake/onnxruntime_mlas.cmake. Signed-off-by: Colm Donelan <[email protected]>
Contributor
Author
|
@microsoft-github-policy-service agree [company="Arm"] |
Contributor
Author
|
@microsoft-github-policy-service agree company="Arm" |
| set(onnxruntime_EXTERNAL_LIBRARIES ${onnxruntime_EXTERNAL_LIBRARIES} PARENT_SCOPE) | ||
|
|
||
| if(onnxruntime_KLEIDIAI_SME_DISABLED) | ||
| target_compile_definitions(onnxruntime_mlas PRIVATE onnxruntime_KLEIDIAI_SME_DISABLED=1) |
Member
There was a problem hiding this comment.
Does this need exposing via build.py as well ?
Contributor
Author
There was a problem hiding this comment.
I was going to avoid putting this in build.py. Users can specify "--cmake_extra_defines onnxruntime_KLEIDIAI_SME_DISABLED=1" instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a cmake compile time parameter to disable the use of SME by KleidiAI.
Motivation and Context
There are occasions during testing that some users wish to compare the relative performance of a model both with and without the SME CPU feature. This change adds a cmake parameter, onnxruntime_KLEIDIAI_SME_DISABLED, to enable this.
In addition there was an error in the handling of the existing onnxruntime_KLEIDIAI_KERNEL_LOGGING and onnxruntime_KLEIDIAI_KERNEL_LOGGING compile time parameters. The definition in cmake/onnxruntime_mlas.cmake did not match the usage in onnxruntime/core/mlas/lib/kleidiai/mlasi_kleidiai.h.