Revert "Consistent with the configuration in the packaged cmake" #26767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit e824331.
Member
Author
|
The optional Lint failure can be ignored - IIRC the original PR had the same issue. |
guschmue
approved these changes
Dec 15, 2025
Sumit2318
pushed a commit
that referenced
this pull request
Jan 6, 2026
) Reverts #26104 It seems like this fix although is correct and necessary, it needs some patches in some other places (like release pipelines and onnxruntime inference examples). We will try and address the actual issue the PR was addressing in a subsequent release. I will re-open all the GH issues that the fix PR closed out so that the actual issue is still tracked. Will reopen: #24003 #26186 #23642 #25279 #25242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26104
It seems like this fix although is correct and necessary, it needs some patches in some other places (like release pipelines and onnxruntime inference examples). We will try and address the actual issue the PR was addressing in a subsequent release. I will re-open all the GH issues that the fix PR closed out so that the actual issue is still tracked.
Will reopen:
#24003
#26186
#23642
#25279
#25242