Embedding ETW Name-GUID Mapping for Log Forward Service#2617
Draft
marma-dev wants to merge 1 commit intomicrosoft:mainfrom
Draft
Embedding ETW Name-GUID Mapping for Log Forward Service#2617marma-dev wants to merge 1 commit intomicrosoft:mainfrom
marma-dev wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Signed-off-by: Manish Ranjan Mahanta <mmahanta@microsoft.com>
MahatiC
reviewed
Mar 3, 2026
Member
There was a problem hiding this comment.
The default log sources should live on the guest side so that they can be measured.
rawahars
reviewed
Mar 4, 2026
| // Make a call to the GCS to set the ETW providers | ||
|
|
||
| var settings string | ||
| if uvm.disableDefaultLogSources { |
Contributor
There was a problem hiding this comment.
Can this logic go into the gcs-sidecar as it's guest side validation?
We want to keep the shim layer as lean as possible and conformant across LCOW and WCOW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the updated design for CWCOW, Adding a ETW name-GUID map in hcsshim.
The user should only provide ETW Provider Name only for well-known GUIDs (in etw-map.json).
HCSShim will append the default list of providers (if the annotation is not set to disable default log sources) with or without GUID depending on whether its WCOW or CWCOW respectively.
For CWCOW, the sidecar GCS will intercept the message with the list of providers, check it against the policy and add the GUIDs by looking up the etw-map to the allowed providers before forwarding it to the inbox GCS within the UVM.
Annotations have been updated as per the design discussion
io.microsoft.virtualmachine.forwardlogs.sources" : Customer defined log sources can be specified as base64 encoded jsonio.microsoft.virtualmachine.forwardlogs.disable"Annotation to disable forwarding logs to the host, Defaults to false for (non-confidential) WCOW, meaning logs will be forwarded to the host if LogSources is set. And true for confidential containers, meaning logs will not be forwarded to the host by default. "Master Switch for Enabling Log Forwarding"io.microsoft.virtualmachine.forwardlogs.defaultsources.disable" - Specifies whether to disable default providers or not. Defaults to true. (Valid only ifio.microsoft.virtualmachine.forwardlogs.disableisfalse