Skip to content

CWCOW: roothash and graceful timeout fixes #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MahatiC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CWCOW: roothash and graceful timeout fixes #2593

MahatiC wants to merge 2 commits into from
+35 −15

Conversation

@MahatiC
Copy link
Member

@MahatiC MahatiC commented Jan 28, 2026

This PR has two changes:

  • Replace base64 encoding of roothash with hex encoding for better standardization and also parity with how C-LCOW does it.
  • Have a graceful timeout when waiting for SCSI devices to show up inside the UVM.

@MahatiC MahatiC requested a review from a team as a code owner January 28, 2026 13:43
@anmaxvl anmaxvl added the cwcow label Jan 28, 2026
helsaawy
helsaawy approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helsaawy helsaawy helsaawy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@anmaxvl anmaxvl

@helsaawy helsaawy

Labels

cwcow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MahatiC @helsaawy @anmaxvl