-
Notifications
You must be signed in to change notification settings - Fork 170
RN-0.81(1) - Add peer dependencies for 0.81, get win32 version 0.81 bundling against the library #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JasonVMo
wants to merge
6
commits into
main
Choose a base branch
from
user/jasonvmo/add-81-peer-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RN-0.81(1) - Add peer dependencies for 0.81, get win32 version 0.81 bundling against the library #3997
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ce3ff71
add win32 test app for 0.81
JasonVMo ff7e681
add peer declarations for 0.78 and 0.81
JasonVMo f375f18
Change files
JasonVMo d39dfb2
fix bundling rn-win32 0.81 against furn
JasonVMo eb71e27
Change files
JasonVMo 98ebc33
centralize .gitattributes
JasonVMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| # Set the default line ending behavior for text, in case people don't have core.autocrlf set. | ||
| * text=auto | ||
| * text=auto | ||
| *.pbxproj -text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # OSX | ||
| # | ||
| .DS_Store | ||
|
|
||
| # Xcode | ||
| # | ||
| build/ | ||
| *.pbxuser | ||
| !default.pbxuser | ||
| *.mode1v3 | ||
| !default.mode1v3 | ||
| *.mode2v3 | ||
| !default.mode2v3 | ||
| *.perspectivev3 | ||
| !default.perspectivev3 | ||
| xcuserdata | ||
| *.xccheckout | ||
| *.moved-aside | ||
| DerivedData | ||
| *.hmap | ||
| *.ipa | ||
| *.xcuserstate | ||
| project.xcworkspace | ||
|
|
||
| # Android/IntelliJ | ||
| # | ||
| build/ | ||
| .idea | ||
| .gradle | ||
| local.properties | ||
| *.iml | ||
|
|
||
| # node.js / web | ||
| # | ||
| node_modules/ | ||
| node_modules/**/* | ||
| npm-debug.log | ||
| yarn-error.log | ||
| npm-debug.* | ||
| *.jks | ||
| *.p8 | ||
| *.p12 | ||
| *.key | ||
| *.mobileprovision | ||
| *.orig.* | ||
| web-build/ | ||
| web-report/ | ||
|
|
||
| # BUCK | ||
| buck-out/ | ||
| \.buckd/ | ||
| *.keystore | ||
|
|
||
| # fastlane | ||
| # | ||
| # It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the | ||
| # screenshots whenever they are needed. | ||
| # For more information about the recommended setup visit: | ||
| # https://docs.fastlane.tools/best-practices/source-control/ | ||
|
|
||
| */fastlane/report.xml | ||
| */fastlane/Preview.html | ||
| */fastlane/screenshots | ||
|
|
||
| # Bundle artifact | ||
| *.bundle | ||
|
|
||
| # CocoaPods | ||
| /ios/Pods/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| yarn-error.log | ||
|
|
||
| # Build targets | ||
| !dist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # Running the FluentUI Tester on Win32 | ||
|
|
||
| `FluentUI Tester` is the test app that we use to test our FluentUI components during development. | ||
|
|
||
| ## Launch `FluentUI Tester` app on Win32 | ||
|
|
||
| 1. Make sure you've installed the Standard React Native dependencies and Node.js from the [Prerequisites](https://github.com/microsoft/fluentui-react-native/tree/main?tab=readme-ov-file#prerequisites) section. | ||
|
|
||
| 2. Next, [clone and build the repo](https://github.com/microsoft/fluentui-react-native/tree/main?tab=readme-ov-file#setup-your-development-environment). If you already have a clone of the repo, make sure you've pulled the latest from the main branch (run `git pull` from your clone's main branch). You can verify you have the latest commits by running `git log` which lists all the commits from your branch with dates. Ensure commits are from a recent date or match the latest commits [here](https://github.com/microsoft/fluentui-react-native/commits/main). To exit the `git log` view, press the letter 'q' (for "quit"). | ||
|
|
||
| 3. Then go into `apps\win32` folder: | ||
|
|
||
| ``` | ||
| cd apps\win32 | ||
| ``` | ||
|
|
||
| 3. Build the FluentUI Tester bundle: | ||
|
|
||
| ``` | ||
| yarn bundle | ||
| ``` | ||
|
|
||
| 4. Launch the FluentUI Tester app: | ||
|
|
||
| ``` | ||
| yarn run-win32 | ||
| ``` | ||
|
|
||
| 5. You will see the FluentUI Tester show up in a new window. | ||
|
|
||
|  | ||
|
|
||
| ## Debug `FluentUI Tester` app with direct debugging | ||
|
|
||
| Note: we recommend using Visual Studio Code for direct debugging. | ||
|
|
||
| 1. Follow steps #1-3 above. | ||
| 2. Build the FluentUI Tester bundle with dev option. This will ensure source map is included in the bundle. | ||
|
|
||
| ``` | ||
| yarn bundle-dev | ||
| ``` | ||
|
|
||
| 3. Launch the FluentUI Tester app: | ||
|
|
||
| ``` | ||
| yarn run-win32 | ||
| ``` | ||
|
|
||
| 4. Inside ReactTest, open the debug option menu and select the checkbox `Use Direct Debugger` | ||
|
|
||
|  | ||
|
|
||
| 5. In Visual Studio Code, open the debug pane and select `Debug Fabric Tester` option from the "Run And Debug" dropdown. | ||
|
|
||
|  | ||
|
|
||
| 6. At this time, VS Code will attach to the JS runtime and you can start debugging | ||
|
|
||
| ## Dependencies | ||
|
|
||
| Dependencies are managed by | ||
| [`@rnx-kit/align-deps`](https://github.com/microsoft/rnx-kit/tree/main/packages/align-deps). | ||
| If you're looking to upgrade `react-native`, use the interactive upgrade command: | ||
|
|
||
| ```sh | ||
| yarn rnx-align-deps --set-version | ||
| ``` | ||
|
|
||
| This command will ensure that all relevant packages are bumped correctly. | ||
|
|
||
| You can read more about this tool here: | ||
| [`@rnx-kit/align-deps` design document](https://github.com/microsoft/rnx-kit/blob/main/docsite/docs/architecture/dependency-management.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "FluentTester", | ||
| "displayName": "FluentTester" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require('@fluentui-react-native/babel-config'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| const baseConfig = require('@fluentui-react-native/eslint-config-rules'); | ||
|
|
||
| module.exports = baseConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| require('./src/index'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * Metro configuration for React Native | ||
| * https://github.com/facebook/react-native | ||
| * | ||
| * @format | ||
| */ | ||
| const { exclusionList, makeMetroConfig, resolveUniqueModule } = require('@rnx-kit/metro-config'); | ||
| const MetroSymlinksResolver = require('@rnx-kit/metro-resolver-symlinks'); | ||
| const { getDefaultConfig } = require('metro-config'); | ||
| const { MetroSerializer } = require('@rnx-kit/metro-serializer-esbuild'); | ||
|
|
||
| const { sourceExts, assetExts } = getDefaultConfig.getDefaultValues().resolver; | ||
|
|
||
| const excludeMixins = []; | ||
| const extraNodeModules = {}; | ||
| function ensureUniqueModule(moduleName, excludeList, nodeModules) { | ||
| const [nmEntry, excludePattern] = resolveUniqueModule(moduleName); | ||
| excludeMixins.push(excludePattern); | ||
| extraNodeModules[moduleName] = nmEntry; | ||
| } | ||
|
|
||
| // build up the added excludes and extraNodeModules | ||
| ['react-native-svg', '@office-iss/react-native-win32', 'react-native'].forEach((moduleName) => ensureUniqueModule(moduleName)); | ||
|
|
||
| module.exports = makeMetroConfig({ | ||
| resolver: { | ||
| assetExts: [...assetExts.filter((ext) => ext !== 'svg'), 'ttf', 'otf', 'png'], | ||
| blockList: exclusionList(excludeMixins), | ||
| extraNodeModules: { | ||
| ...extraNodeModules, | ||
| }, | ||
| sourceExts: [...sourceExts, 'svg'], | ||
| resolveRequest: MetroSymlinksResolver({ | ||
| resolver: 'oxc-resolver', | ||
| }), | ||
| }, | ||
| serializer: { | ||
| customSerializer: MetroSerializer(), | ||
| }, | ||
| transformer: { | ||
| // This transformer selects between the regular transformer and svg transformer depending on the file type | ||
| babelTransformerPath: require.resolve('react-native-svg-transformer'), | ||
| }, | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.