Open
Conversation
fix: sync main with dev Update Deployment Guide with azd version 1.23.9 note
fix: update VM size defaults and enhance troubleshooting documentation for the same
fix: Fixed issues related to intermittent WAF deployment failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the deployment defaults and documentation for jumpbox VM sizing, enhances error troubleshooting guidance, and refactors private endpoint provisioning for AI services to use standalone modules. The changes aim to make deployments more reliable across regions, clarify error messages and resolutions, and align infrastructure code with best practices for Azure networking.
Deployment defaults and documentation improvements:
Standard_DS2_v2toStandard_D2s_v5ininfra/main.bicep, updated parameter passing ininfra/main.waf.parameters.json, and revised documentation to reflect the new default and provide guidance on selecting compatible VM sizes. This ensures better regional availability, performance, and compatibility with accelerated networking and Premium SSD. [1] [2] [3] [4]Troubleshooting and error documentation enhancements:
docs/TroubleShootingSteps.mdto include detailed guidance and resolutions for SKU availability errors and accelerated networking requirements, specifically referencing the new default VM size and supported alternatives. [1] [2]Infrastructure and private endpoint refactoring:
infra/main.bicepto use standaloneprivate-endpointmodules, improving clarity and modularity. The new modules explicitly define private link service connections and DNS zone group configurations, and remove the previous inline array-based approach. [1] [2] [3] [4]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information