-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Hide omitted expression types in type baselines #63081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the type-baseline writer to suppress type output for OmittedExpression nodes (array holes / elisions), aligning baseline output with tsgo comparison needs.
Changes:
- Skip writing types for
ts.isOmittedExpression(node)in the type baseline walker. - Regenerate affected
.typesbaselines to remove: undefinedentries corresponding to omitted expressions.
Reviewed changes
Copilot reviewed 91 out of 91 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/baselines/reference/unusedParametersWithUnderscore.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/trailingCommasES5(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/trailingCommasES5(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/strictOptionalProperties1.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/strictNullChecksNoWidening.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/spreadTupleAccessedByTypeParameter.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues3(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues3(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern3(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern3(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern2(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern2(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/restParameterWithBindingPattern3.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression8.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression4.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression3.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression2.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression15.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression14.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression13.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression12.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/parserArrayLiteralExpression11.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/optionalTupleElements1.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/omittedExpressionForOfLoop.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/noUncheckedIndexedAccessDestructuring.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/isolatedDeclarationErrorsExpressions.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/initializedDestructuringAssignmentTypes.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/flatArrayNoExcessiveStackDepth.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/exportArrayBindingPattern.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/emptyAssignmentPatterns01_ES5(target=es5).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/emptyAssignmentPatterns01_ES5(target=es2015).types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/emitArrowFunctionES6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringVariableDeclaration2.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringVariableDeclaration1ES6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringVariableDeclaration1ES5iterable.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringVariableDeclaration1ES5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringParameterDeclaration1ES6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringParameterDeclaration1ES5iterable.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringParameterDeclaration1ES5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES5iterable.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/destructuredDeclarationEmit.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/declarationsAndAssignments.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/declarationEmitDestructuringArrayPattern5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/declarationEmitDestructuringArrayPattern1.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/declarationEmitDestructuring5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/commentOnArrayElement3.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/commentOnArrayElement12.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/commentOnArrayElement11.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/commentOnArrayElement10.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/coAndContraVariantInferences3.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/bindingPatternOmittedExpressionNesting.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/asyncWithVarShadowing_es6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/arrowFunctionExpressions.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/arrayLiterals2ES6.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/arrayLiterals2ES5.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/arrayLiteralWidened.types | Baseline update: remove type entries emitted for omitted expressions. |
| tests/baselines/reference/arrayBindingPatternOmittedExpressions.types | Baseline update: remove type entries emitted for omitted expressions. |
| src/harness/typeWriter.ts | Suppress type output for OmittedExpression nodes during type-baseline generation. |
andrewbranch
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compat change needed for comparing tsgo to this repo. Pull it out of
tsgo-portintomain.Omitted expressions are actual nodes here, and so get their types printed in types baselines, but in tsgo they are not "real" and don't.