Skip to content

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Feb 3, 2026

This is a compat change needed for comparing tsgo to this repo. Pull it out of tsgo-port into main.

Omitted expressions are actual nodes here, and so get their types printed in types baselines, but in tsgo they are not "real" and don't.

Copilot AI review requested due to automatic review settings February 3, 2026 05:30
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Feb 3, 2026
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the type-baseline writer to suppress type output for OmittedExpression nodes (array holes / elisions), aligning baseline output with tsgo comparison needs.

Changes:

  • Skip writing types for ts.isOmittedExpression(node) in the type baseline walker.
  • Regenerate affected .types baselines to remove : undefined entries corresponding to omitted expressions.

Reviewed changes

Copilot reviewed 91 out of 91 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/baselines/reference/unusedParametersWithUnderscore.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/trailingCommasES5(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/trailingCommasES5(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/strictOptionalProperties1.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/strictNullChecksNoWidening.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/spreadTupleAccessedByTypeParameter.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues3(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues3(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPatternDefaultValues(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern3(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern3(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringVariableStatementArrayBindingPattern(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPatternDefaultValues(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringParametertArrayBindingPattern(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPatternDefaultValues(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForOfArrayBindingPattern(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPatternDefaultValues(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern2(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern2(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/sourceMapValidationDestructuringForArrayBindingPattern(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/restParameterWithBindingPattern3.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression8.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression4.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression3.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression2.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression15.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression14.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression13.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression12.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/parserArrayLiteralExpression11.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/optionalTupleElements1.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/omittedExpressionForOfLoop.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/noUncheckedIndexedAccessDestructuring.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/isolatedDeclarationErrorsExpressions.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/initializedDestructuringAssignmentTypes.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/flatArrayNoExcessiveStackDepth.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/exportArrayBindingPattern.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/emptyAssignmentPatterns01_ES5(target=es5).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/emptyAssignmentPatterns01_ES5(target=es2015).types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/emitArrowFunctionES6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringVariableDeclaration2.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringVariableDeclaration1ES6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringVariableDeclaration1ES5iterable.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringVariableDeclaration1ES5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringParameterDeclaration1ES6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringParameterDeclaration1ES5iterable.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringParameterDeclaration1ES5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES5iterable.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuringArrayBindingPatternAndAssignment1ES5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/destructuredDeclarationEmit.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/declarationsAndAssignments.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/declarationEmitDestructuringArrayPattern5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/declarationEmitDestructuringArrayPattern1.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/declarationEmitDestructuring5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/commentOnArrayElement3.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/commentOnArrayElement12.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/commentOnArrayElement11.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/commentOnArrayElement10.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/coAndContraVariantInferences3.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/bindingPatternOmittedExpressionNesting.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/asyncWithVarShadowing_es6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/arrowFunctionExpressions.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/arrayLiterals2ES6.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/arrayLiterals2ES5.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/arrayLiteralWidened.types Baseline update: remove type entries emitted for omitted expressions.
tests/baselines/reference/arrayBindingPatternOmittedExpressions.types Baseline update: remove type entries emitted for omitted expressions.
src/harness/typeWriter.ts Suppress type output for OmittedExpression nodes during type-baseline generation.

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Feb 3, 2026
@jakebailey jakebailey added this pull request to the merge queue Feb 3, 2026
Merged via the queue into microsoft:main with commit 43db4c1 Feb 3, 2026
38 of 39 checks passed
@jakebailey jakebailey deleted the tsgo-compat-port-1 branch February 3, 2026 16:06
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants