Skip to content

Comments

Revert "Added debug info for localized global variables for inlined scopes" (#7799)#8182

Closed
Copilot wants to merge 2 commits intorelease-1.9.2602from
copilot/revert-pull-7799-change
Closed

Revert "Added debug info for localized global variables for inlined scopes" (#7799)#8182
Copilot wants to merge 2 commits intorelease-1.9.2602from
copilot/revert-pull-7799-change

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

Reverts PR #7799 from the 1.9.2602 release branch due to a bug introduced by that change.

Changes

  • lib/Transforms/Scalar/ScalarReplAggregatesHLSL.cpp
    • Removed GVDebugInfoPatchCache struct and its m_GVDebugInfoCache member from LowerStaticGlobalIntoAlloca
    • Reverted PatchDebugInfo() to original single-subprogram implementation — only creates dbg.value for the entry function's DISubprogram rather than iterating all inlined subprograms
  • Deleted tests added by Added debug info for localized global variables for inlined scopes. #7799:
    • tools/clang/test/HLSLFileCheck/dxil/debug/local_global_inline_scope.hlsl
    • tools/clang/test/HLSLFileCheckLit/passes/dxil/static_global_to_alloca/local_global_inline_scope.ll

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

… inlined scopes

Co-authored-by: alsepkow <5620315+alsepkow@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert change in 1.9.2602 release branch due to bug Revert "Added debug info for localized global variables for inlined scopes" (#7799) Feb 20, 2026
Copilot AI requested a review from alsepkow February 20, 2026 02:46
@damyanp damyanp closed this Feb 20, 2026
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants