Disambiguate UpdateTileMappings function usage#802
Open
hadalhw17 wants to merge 1 commit intomicrosoft:masterfrom
Open
Disambiguate UpdateTileMappings function usage#802hadalhw17 wants to merge 1 commit intomicrosoft:masterfrom
hadalhw17 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
hadalhw17
commented
Nov 8, 2022
- According to official docs(https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12commandqueue-updatetilemappings?redirectedfrom=MSDN), UpdateTileMappings is only taking a pointer to a single heap(allowing multiple offsets into this heap, but not multiple heaps). The sample is iterating over multiple heaps and tries to map tiles to them in a single UpdateTileMappings call. While this doesn't break the functionality of the sample, in a real world applications with more complicated heap usage patterns, this wouldn't work.
- According to official docs, UpdateTileMappings is only taking a pointer to a single heap(allowing multiple offsets into this heap, but not multiple heaps). While this doesn't break the functionality of the sample, this would't work in real applications
Contributor
|
@hadalhw17 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.