Port ComImportInterfaceAnalyzer to WinRT.SourceGenerator2#2355
Open
Sergio0694 wants to merge 2 commits intostaging/3.0from
Open
Port ComImportInterfaceAnalyzer to WinRT.SourceGenerator2#2355Sergio0694 wants to merge 2 commits intostaging/3.0from
Sergio0694 wants to merge 2 commits intostaging/3.0from
Conversation
Port the ComImportInterfaceAnalyzer diagnostic analyzer from the legacy WinRT.SourceGenerator project to WinRT.SourceGenerator2. This analyzer warns for casts to [ComImport] interfaces, which are not compatible with CsWinRT objects in AOT scenarios. Changes: - Add CSWINRT2009 diagnostic descriptor to DiagnosticDescriptors.cs - Add ComImportInterfaceAnalyzer in Diagnostics/Analyzers - Update AnalyzerReleases.Shipped.md with the new rule Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Port the ComImportInterfaceAnalyzer unit tests to the SourceGenerator2Test project, validating that: - Casts to non-[ComImport] interfaces do not produce warnings - Casts to [ComImport] interfaces produce CSWINRT2009 warnings for all supported patterns (explicit casts, 'as', 'is', declaration patterns, type patterns, and list patterns) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the \ComImportInterfaceAnalyzer\ diagnostic analyzer from the legacy \WinRT.SourceGenerator\ project to \WinRT.SourceGenerator2, along with corresponding unit tests.
Changes
Analyzer (\WinRT.SourceGenerator2)
Tests (\SourceGenerator2Test)
Notes