Clean up legacy test framework #5655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 76f4d6e.
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
compulim
changed the title
OEvgeny
reviewed
Dec 15, 2025
OEvgeny
reviewed
Dec 15, 2025
| customDiffConfig: { | ||
| threshold: 0.06 | ||
| }, | ||
| noColors: true |
Collaborator
There was a problem hiding this comment.
Why no colors? I had one snapshot without theme applied because of this 🤣
Contributor
Author
There was a problem hiding this comment.
noColors: Removes coloring from console output, useful if storing the results in a file
It's about ANSI color. 🤣
OEvgeny
reviewed
Dec 15, 2025
OEvgeny
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Removed
html2test harness or simple unit testshtml(html1) test harness are all migrated tohtml2Description
As we migrated all tests to
html2test infrastructure, this PR will clean up test harness for legacy andhtml1tests.Design
Specific Changes
jest.config.jsonintohtml.setup/jest.config.jsonandunit.setup/jest.config.jsonsetupintohtml.setupandunit.setupLOCALIZATION.mdanddoc/LOCALIZATION.mdCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)