Fix parameter order in User feedback module

[edwardUL99]

Summary

The parameters in the method:
procedure RequestDislikeFeedback(....,..., ContextProperties, ContextFiles)

were in the wrong order.

Moved ContextFiles to before ContextProperties

Work Item(s)

Fixes AB#615527

[edwardUL99]

Not sure if 27.x is enough to be backported or are there other versions too?

[darjoo]

[Groenbech96]

Some changes are affected by this change. Check NAV

[edwardUL99]

@darjoo I wanted the dislike function to be consistent with the like function which has the correct order, but if we should leave as is, I can do that

[darjoo]

@darjoo I wanted the dislike function to be consistent with the like function which has the correct order, but if we should leave as is, I can do that

I understand, however once an api is out, it is a breaking change, or at least semantically in this case.
We don't have any 3p usage, so that is fine. As far as I understand, it is broken even today because the parameters are swapped, so you will need to HF this and 1p/baseapp for their usages if you decide to change the api.

There is the other option, of doing the platform HF on the feedback codeunit instead of this.

[edwardUL99]

@darjoo I wanted the dislike function to be consistent with the like function which has the correct order, but if we should leave as is, I can do that

I understand, however once an api is out, it is a breaking change, or at least semantically in this case. We don't have any 3p usage, so that is fine. As far as I understand, it is broken even today because the parameters are swapped, so you will need to HF this and 1p/baseapp for their usages if you decide to change the api.

There is the other option, of doing the platform HF on the feedback codeunit instead of this.

In the platform API, the parameters are all in the correct order, it's only swapped here

[edwardUL99]

Hi @Groenbech96 if this change still affects changes in NAV, let me know and I can fix them, or else if you want to, let me know