Added Mapping for mcp_meserver. #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two additional mapping entries for the MCP Me Server to enable C# examples to work correctly with the a365 setup permissions mcp command. The mappings provide scope and audience information needed when calling the MCP Me Server API.
Changes:
- Added "MCP_MeServer" mapping with PascalCase convention
- Added "mcp_meserver" mapping with lowercase convention to match expected URL patterns
| // User/Me servers | ||
| ["MCP_MeTools"] = ("McpServers.Me.All", "api://mcp-metools"), | ||
| ["MCP_MeServer"] = ("McpServers.Me.All", "api://mcp-meserver"), | ||
| ["mcp_meserver"] = ("McpServers.Me.All", "api://mcp-meserver"), |
There was a problem hiding this comment.
The naming pattern for "MCP_MeServer" is inconsistent with other similar entries in the mapping. Looking at the existing patterns:
- For "MeTools": line 111 uses "MCP_MeTools" (with underscore after MCP)
- For other servers: lines 77-78 use "MCP_MailTools" and "mcp_MailTools" (preserving the underscore)
- For OneDrive: line 102 uses "mcp_OneDriveServer" (all lowercase with underscore preserved)
Line 113 uses "mcp_meserver" (all lowercase, no underscore between "me" and "server"), which breaks the pattern. It should be "mcp_MeServer" to maintain consistency with the casing pattern seen in "mcp_MailTools", "mcp_CalendarTools", "mcp_NLWeb", and "mcp_OneDriveServer".
Suggested change
| ["mcp_meserver"] = ("McpServers.Me.All", "api://mcp-meserver"), | |
| ["mcp_MeServer"] = ("McpServers.Me.All", "api://mcp-meserver"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two additional mappings for mcp_meserver.
["MCP_MeServer"] = ("McpServers.Me.All", "api://mcp-meserver"),
["mcp_meserver"] = ("McpServers.Me.All", "api://mcp-meserver"),
This is to be consistent with the naming, and also align with the C# Examples when 'a365 setup permissions mcp' is run.
As an example, the SemanticKernel based dotnet example makes a call to the URL defined by the map and since no map is currently available to call "mcp_meserver" (which should be in the main URL), the call fails.