unix-ffi/json: Fix json.loads() of a bytes object.#1084
Open
dhouck wants to merge 1 commit intomicropython:masterfrom
Open
unix-ffi/json: Fix json.loads() of a bytes object.#1084dhouck wants to merge 1 commit intomicropython:masterfrom
dhouck wants to merge 1 commit intomicropython:masterfrom
Conversation
dhouck
force-pushed
the
json-loads-bytes
branch
from
5403e7f to
c73a3fd
Compare
The conversion from bytes to string previosuly only if some other argument was also given to `loads`. This makes even a basic call with no other arguments work. Signed-off-by: Daniel Houck <Software@DRHouck.me>
dhouck
force-pushed
the
json-loads-bytes
branch
from
c73a3fd to
38addcd
Compare
dhouck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion from bytes to string previosuly only if some other argument was also given to
loads. This makes even a basic call with no other arguments work.NOTE: The
test_json.pyfile fails, and failed before this PR, because of #1083. If I patchscanner.pyto only parse ints (and thus not need optional groups), the tests pass.