ASIStage: CRISP improvements, reduce serial traffic when setting the "CRISP State" property#878
Merged
marktsuchida merged 6 commits intomicro-manager:mainfrom Mar 6, 2026
Merged
Conversation
…erial command query in SetFocusState()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer query the focus state 2x with
GetFocusState()before setting the"CRISP State".CRISP Advanced properties
"Set LogAmpAGC (Advanced Users Only)"and"Set Lock Offset (Advanced Users Only)"areMM::Integerproperties and should uselongnotdouble. Sends"LK M=1"instead of"LK M=1.000000".Change CRISP
GetFocusState()toUpdateFocusState()which uses the same logic asASITigerto update thefocusState_member variable.If firmware >= 9.53 is detected, use the shortcut
"EX Y?" instead of"EXTRA Y?"for the"Signal Noise Ratio"` property.Use
static_cast<long>to convert double to long. LogAmpAGC returns":A X=1.000000"and Offset usesGetOffset(double& offset).GetCurrentFocusScore()matches CRISP semantics."LK Y?"returns the current focus score, so we aliasGetLastFocusScore()toGetCurrentFocusScore()instead of the other way around.