Open
Conversation
sebkopf
commented
Nov 6, 2019
hexagontruth
requested changes
Mar 27, 2020
Collaborator
hexagontruth
left a comment
There was a problem hiding this comment.
Two things:
- Both the SVG and PNG have alpha transparency on the image itself, on the main gray background at least. Not sure if this is intentional or not but it will certainly look weird on the site. Can you fix at least the PNG so it doesn't have this?
- Not a big deal and I would otherwise fix it myself but the raster and vector URLs are wrong. (Not sure why this can't be autopopulated but it is what it is.) Obvs see existing files for the format etc.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.