[Internal] Make letter spacing dependent on text size in CollapsingTextHelper #4640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey Hunter, will you able to review this PR? |
hunterstich
added
the
Reviewing Internally
Open
pubiqq
force-pushed
the
internal/adjust-letter-spacing-with-text-size-in-cth
branch
from
587f81f to
9fae0ca
Compare
pubiqq
force-pushed
the
internal/adjust-letter-spacing-with-text-size-in-cth
branch
from
9fae0ca to
6b05f8a
Compare
Contributor
Author
|
Ping |
hunterstich
requested changes
Dec 30, 2025
Comment on lines
-715
to
-725
| if (collapsedLetterSpacing != expandedLetterSpacing) { | ||
| textPaint.setLetterSpacing( | ||
| lerp( | ||
| expandedLetterSpacing, | ||
| collapsedLetterSpacing, | ||
| fraction, | ||
| AnimationUtils.FAST_OUT_SLOW_IN_INTERPOLATOR)); | ||
| } else { | ||
| textPaint.setLetterSpacing(collapsedLetterSpacing); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Instead of removing this block, could it be moved into the else statement of if (fadeModeEnabled)?
if (fadeModeEnabled) {
...
} else {
lerp letter spacing
}
Comment on lines
+1102
to
+1106
| newLetterSpacing = lerp( | ||
| expandedLetterSpacing, collapsedLetterSpacing, | ||
| 1f, collapsedTextSize / expandedTextSize, | ||
| scale); | ||
|
|
Contributor
There was a problem hiding this comment.
No longer needed if letter spacing lerping is replaced inside calculateOffsets
Contributor
|
Hey @pubiqq! I checked this PR internally and it is causes some breakages with TextInputLayout's hint. With this change, when the hint text is collapsed on focus, the hint's letter spacing is smaller than it was previously. I added some comments suggesting an alternative approach. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #4639.