Fix incorrect and nonstandard use of error() #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `error()` function is defined nowhere in this codebase. When linking against glibc, the declaration will match the nonstandard [error(3)] function, but midicomp only ever passes a single `const char*` to this function, which doesn't match its 3+-parameter signature. Consequently, this code fails to link with any other libc, and doesn't correctly show the respective errors even *with* glibc. Using `prs_error()` fixes these issues, allows this code to be compiled with MinGW, and retains the line number in the now correct error output. [error(3)]: https://linux.die.net/man/3/error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
error()function is defined nowhere in this codebase. When linking against glibc, the declaration will match the nonstandard error(3) function, but midicomp only ever passes a singleconst char*to this function, which doesn't match its 3+-parameter signature. Consequently, this code fails to link with any other libc, and doesn't correctly show the respective errors even with glibc.Using
prs_error()fixes these issues, allows this code to be compiled with MinGW, and retains the line number in the now correct error output.