Handle pipe error or disk full/error in bmdcapture push_packet() #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me is ignored. We don't know if the outfile is in a disk error, disk full, or pipe issue state. it seems you planned to do that by defining "ret" as an integer ;) This patch handle this case.
Owner
|
Sounds a good idea to check it indeed! I'll push it with some rewording on the commit message. In theory all the exit causes should have a proper value... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In push_packet functions, the return code of av_interleaved_write_frame is ignored.
We don't know if the outfile is in a disk error, disk full, or pipe issue state.
it seems you planned to do that by defining "ret" as an integer ;)
This patch handle this case.