SP-2716: NB 200, 300 use CoaddPatches #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MelissaGraham
requested changes
Jan 28, 2026
Contributor
MelissaGraham
left a comment
MelissaGraham
left a comment
There was a problem hiding this comment.
For 201.12:
- don't need to import or instantiate butler as it's not used
- filter names and colors aren't used
- delete code cells 8 and 9 (and associated markdown) since there are so few columns in this table, a demo of how to explore the column names is not needed
- section 3 says coadd patches is available via the butler but it's not
For the 301-series: yes perfect. I'd hoped that switching to CoaddPatches would enable drawing vertices in fewer lines of code, but I think it's not possible; AFAIK you've found the shortest way to do it. All good though, keep going.
Contributor
Author
|
Thank you. I've adjusted 201.12. |
Contributor
Author
|
@MelissaGraham I've updated all 301 notebooks. Could you review them? |
MelissaGraham
approved these changes
Jan 30, 2026
shenmingfu
force-pushed
the
tickets/SP-2716
branch
from
ffe033b to
a4033e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.