DM-48354: Invalid diffim pixels in AP forced photometry#382
Open
DM-48354: Invalid diffim pixels in AP forced photometry#382
Conversation
abudlong
requested review from
kfindeisen
and removed request for
kfindeisen
abudlong
force-pushed
the
tickets/DM-48354
branch
2 times, most recently
from
3f7cf6a to
3759b03
Compare
bsmartradio
approved these changes
Feb 20, 2025
Contributor
bsmartradio
left a comment
bsmartradio
left a comment
There was a problem hiding this comment.
In general this looks good, but there should be a new unit test added to test_getTemplate.py to ensure this is working as intended.
bsmartradio
requested changes
Feb 20, 2025
abudlong
force-pushed
the
tickets/DM-48354
branch
from
4761e66 to
2548118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.