Skip to content

Conversation

@gstrauss
Copy link

build with mbedtls 3.x. This patch should also still work with mbedtls 2.28.x.

This patch simply adds MBEDTLS_PRIVATE() to access now-private mbedtls 3.x struct members.

Note: mbedtls 3.6.0 adds some helper functions which would allow cups_verifySig() to avoid using MBEDTLS_PRIVATE(), but that change is not included in this patch.

Signed-off-by: Glenn Strauss <[email protected]>
@gstrauss gstrauss force-pushed the build-with-mbedtls-3.x branch from ce5b152 to 120c581 Compare July 19, 2024 17:39
@Neustradamus
Copy link

To follow this ticket.

@gstrauss
Copy link
Author

@Neustradamus if after this many years, you still have not learned how to click the "Subscribe" button to the right instead of useless posts, you are more annoying than helpful. Please avoid making useless posts.

@Neustradamus
Copy link

@gstrauss: Always same, I receive only e-mails if I comment the issues/PRs... I follow a lot of projects...

@gstrauss
Copy link
Author

@Neustradamus you are technologically inept. If you are logged into github, look at the section on the right. There will be a button which says "Subscribe" (if you have not subscribed to this issue/pull request) or "Unsubscribe" (if you have subscribed to this issue/pull request) Above the button it says "Notifications Customize". You can click that to further customize notifications. When you click the Subscribe button in a single issue or pull request, that triggers the same notifications for the issue/pull request that occur as when you comment.

Stop commenting garbage just to enable notifications, you buffoon!

Instead, click the Subscribe button to the issue/pull request to enable notifications for the specific issue/pull request.

feckert added a commit to TDT-AG/packages that referenced this pull request Aug 16, 2024
The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <[email protected]>
feckert added a commit to TDT-AG/packages that referenced this pull request Aug 19, 2024
The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <[email protected]>
neheb pushed a commit to openwrt/packages that referenced this pull request Aug 19, 2024
The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <[email protected]>
liudf0716 pushed a commit to liudf0716/packages that referenced this pull request Aug 26, 2024
The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <[email protected]>
@gstrauss
Copy link
Author

@beitler ping.

On Aug 19 in #201 you said:

Having said that, I think upgrading mbedtls to version 3.x is a valid request.

Is this PR helpful to you, or are you planning to take a different approach?

@basprins
Copy link

We are about to get started integrating lorawan into our product. I just finished integrating mbedtls (3.6) and now I see that lorawan depends on mbedtls 2.x.

Then i came across this pull request. Any reason why this is not merged? I don't mind starting our integration on this branch, but if there are reasons why this won't get merged into master I was hoping to learn the reason.

Many thanks in advance

pschmitt pushed a commit to pschmitt/packages that referenced this pull request Feb 20, 2025
The basicstation build fails since the change to the new major version
3.x of mbedtls, because of API changes in the new mbedtls version.

To fix the compilation for new mbedtls version, the waiting pullrequest
is backported as a patch.

Thanks to 'Glenn Strauss' to create this PR:
lorabasics/basicstation#198

Signed-off-by: Florian Eckert <[email protected]>
trimpim added a commit to trimpim/basicstation that referenced this pull request Sep 30, 2025
After updating to 3.4.x parsing of certificates returned by the CUPS
service of Actility weren't parsed correctly anymore.

This fixes the parsing.

Issue lorabasics#198
@trimpim
Copy link

trimpim commented Sep 30, 2025

When testing 665141d with Actility, parsing of the certificates downloaded via CUPS failed.

I created a patch that fixes the parsing, but I'm not sure, if there would be a better way to fix it.

sidhussmann added a commit to sidhussmann/basicstation that referenced this pull request Oct 1, 2025
Fix parsing of DER formatted keys while still supporting PEM.

The problem arises when using `mbedtls_pk_parse_key()` the caller needs
to know beforehand which format the key has to decide whether the
`keylen` needs to account for the zero terminator.

Since mbedtls knows best how to parse the respective formats,
we switch from `mbedtls_pk_parse_key()` to `mbedtls_pk_parse_keyfile()`
on latest mbedtls version.

Issue lorabasics#198
@sidhussmann
Copy link

While trimpim@089c817 fixed the handling of DER formatted keys, it introduced a regression on PEM keys. sidhussmann@383fc6e fixes the key handling for DER as well as PEM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants