[TorchToLinalg] Fix outType inconsistency in AtenTransposeInt op lowering #4403
+138
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oseInt op lowering This commit adds the support to handle output tensor type consistency in case of dynamic dims for AtenTransposeInt op lowering by adding a cast operation to ensure the output tensor type matches the expected type. Also, update tests in datamovement.mlir to reflect changes in tensor handling for dynamic dimensions in transpose operations. Example IR: """ %0 = torch.prim.ListConstruct %int1, %int8, %int7, %int8, %int7, %int96 : (!torch.int, !torch.int, !torch.int, !torch.int, !torch.int, !torch.int) -> !torch.list<int> %1 = torch.aten.view %arg0, %0 : !torch.vtensor<[1,56,56,96],f32>, !torch.list<int> -> !torch.vtensor<[?,?,?,?,?,?],f32> %2 = torch.aten.transpose.int %1, %int2, %int3 : !torch.vtensor<[?,?,?,?,?,?],f32>, !torch.int, !torch.int -> !torch.vtensor<[?,?,?,?,?,?],f32> """
sahas3
reviewed
Dec 11, 2025
… for identity permutation
Collaborator
Author
|
@sahas3 Can you please review the PR now? |
sahas3
approved these changes
Dec 19, 2025
Comment on lines
+712
to
+715
| bool inputAllStatic = llvm::none_of( | ||
| inputSizes, [](int64_t size) { return size == Torch::kUnknownSize; }); | ||
| bool outputAllStatic = llvm::none_of( | ||
| outputSizes, [](int64_t size) { return size == Torch::kUnknownSize; }); |
Member
There was a problem hiding this comment.
I think we can use type.areAllSizesKnown() here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support to handle output tensor type consistency in case of dynamic dims for AtenTransposeInt op lowering by adding a cast operation to ensure the output tensor type matches the expected type.
Also, update tests in datamovement.mlir to reflect changes in tensor handling for dynamic dimensions in transpose operations.
Example IR: