-
Notifications
You must be signed in to change notification settings - Fork 11
[testing] Tests mark themselves UNSUPPORTED if features aren't available #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
E.g. if you didn't install torch dependencies (e.g. did And if you then install Without this change the above UNSUPPORTED tests would show FAILED instead. |
tkarna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. At the moment we are only testing the "everything is installed" case in CI, right?
|
why is the kernelbench still unsupported after installing torch? |
The example speaks for itself 😉 |
e5dd205 to
efff1b1
Compare
Indeed. If people want this UNSUPPORTED mechanism tested in CI as well, do let me know. |
b58358f to
84fd5fb
Compare
Also loosens dependency upon `uv` for running tests -- all that is required is that `lit` is running in a suitable environemnt (e.g. through `uv run lit .` or by first entering an venv and then `lit .`).
Means at least one more example can run without torch being installed.
1# with '#' will be ignored, and an empty message aborts the commit.
84fd5fb to
64bf0ab
Compare
64bf0ab to
e13be22
Compare
Also loosens dependency upon
uvfor running tests -- all that is required is thatlitis running in a suitable environment (e.g. throughuv run lit .or by first entering an venv and thenlit .).Also splits
lighthouse.utilsinto two so that the examples/tests that don't actually depend ontorchaccidently end up with that dependency (there was one such such instance already).