feat(rtc): add restart_publisher method to Room#571
Closed
Hormold wants to merge 1 commit intolivekit:mainfrom
Closed
feat(rtc): add restart_publisher method to Room#571Hormold wants to merge 1 commit intolivekit:mainfrom
Hormold wants to merge 1 commit intolivekit:mainfrom
Conversation
Add `restart_publisher()` method stub to the Room class. This method will perform an ICE restart on the publisher PeerConnection when implemented. Use case: When sending data (stream_text/publish_data) times out but receiving audio/video continues to work, the publisher PeerConnection may be stuck. Currently there's no way to recover without disconnecting the entire room. This is a placeholder that raises NotImplementedError until the corresponding FFI bindings are added to livekit/rust-sdks. Co-Authored-By: Claude Opus 4.5 <[email protected]>
8cd27d3 to
cfa04b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restart_publisher()method stub to theRoomclassNotImplementedErroras a placeholder until FFI bindings are added to rust-sdksMotivation
When using the Python SDK for real-time meeting applications, we encountered a scenario where:
stream_text(),publish_data(), etc. times outCurrently, there's no way to recover from this state without disconnecting the entire room, which breaks the audio streams.
The Rust SDK already has
restart_publisher()at the engine level (inrtc_session.rs):This PR adds a placeholder method that will be fully implemented once the FFI bindings are added.
Usage (Future)
Implementation Status
This is a stub implementation that raises
NotImplementedError:Next Steps
To fully implement this feature:
RestartPublisherRequest,RestartPublisherResponse,RestartPublisherCallbackinroom.protorequests.rsrestart_publisher()onRoomandRtcEngineTest Plan
🤖 Generated with Claude Code