[WIP] Fix IndexError when editing legacy webapps missing browser metadata#364
Open
PeterDaveHello wants to merge 1 commit intolinuxmint:masterfrom
Open
[WIP] Fix IndexError when editing legacy webapps missing browser metadata#364PeterDaveHello wants to merge 1 commit intolinuxmint:masterfrom
PeterDaveHello wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Commit 247f167 added browser restoration during edit but assumed X-WebApp-Browser always exists. Legacy desktop files miss that key, so on_edit_button hits IndexError at line 366, the GTK main loop stalls, and CPU usage spikes. Match by Exec when the name lookup fails, and fall back if nothing fits. Editing now completes and rewrites the desktop file with fresh metadata. Fix linuxmint#345
44854b3 to
71c76ef
Compare
Contributor
Author
|
@clefebvre, could you help review whether this PR can be accepted? Thank you! |
Member
|
Maybe you could use python's argparse module to parse the exec line? This might result in a much smaller diff than what we have here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 247f167(PR #202) added browser restoration during edit, but assumed X-WebApp-Browser always exists. Legacy desktop files miss that key, so on_edit_button hits IndexError at line 366, the GTK main loop stalls, and CPU usage spikes.
Match by Exec when the name lookup fails, and fall back if nothing fits. Editing now completes and rewrites the desktop file with fresh metadata.
Fix #345
PR summary from GitHub Copilot: