Skip to content

chore: change slack app webhooks (CM-1019)#3926

Closed
themarolt wants to merge 6 commits intomainfrom
change-slack-app-webhooks-CM-1019
Closed

chore: change slack app webhooks (CM-1019)#3926
themarolt wants to merge 6 commits intomainfrom
change-slack-app-webhooks-CM-1019

Conversation

@themarolt
Copy link
Contributor

@themarolt themarolt commented Mar 18, 2026

Note

Medium Risk
Moderate operational risk: all Slack notifications are rerouted to new CDP_* channels and env var names, so missing/incorrect webhook configuration could silently drop alerts.

Overview
Migrates Slack alerting to a new set of CDP_* webhook channels by replacing the SlackChannel enum values and updating all call sites (API/public API error reporting, cron monitoring jobs, Temporal worker alerts, and Snowflake connector schedules) to use the new channels.

Removes the legacy slackAlerting config/env wiring from backend and workers, and updates the Slack library to read webhook URLs from CDP_*_SLACK_WEBHOOK_URL env vars with clearer missing-config warnings.

Written by Cursor Bugbot for commit cacaf62. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings March 18, 2026 08:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Slack alerting by renaming/re-scoping Slack channels (and their corresponding webhook environment variables) to a new CDP-prefixed set, while removing the older slackAlerting configuration wiring from multiple services.

Changes:

  • Replaced legacy Slack channels (ALERTS, DATA_ALERTS, etc.) with CDP-scoped channels (e.g., CDP_ALERTS, CDP_CRITICAL_ALERTS).
  • Updated services to send notifications to the new channels.
  • Removed slackAlerting config types + environment variable mappings from backend and workers.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/libs/slack/src/types.ts Renames/defines the canonical Slack channel enum values.
services/libs/slack/src/client.ts Updates missing-webhook warning to match new env var naming.
services/libs/slack/src/channels.ts Switches webhook env var lookup to CDP_*_SLACK_WEBHOOK_URL variables.
services/archetypes/worker/src/activities/index.ts Routes archetype worker Slack notifications to CDP_ALERTS.
services/archetypes/worker/src/activities/activityInterceptor.ts Routes interceptor alerts to CDP_ALERTS.
services/apps/snowflake_connectors/src/schedules/snowflakeS3Export.ts Sends integration schedule failures to CDP_INTEGRATIONS_ALERTS.
services/apps/snowflake_connectors/src/schedules/snowflakeS3Cleanup.ts Sends integration schedule failures to CDP_INTEGRATIONS_ALERTS.
services/apps/snowflake_connectors/src/activities/cleanupActivity.ts Sends cleanup failures to CDP_INTEGRATIONS_ALERTS.
services/apps/integration_run_worker/src/conf/index.ts Removes slackAlerting config accessor/types.
services/apps/integration_run_worker/config/custom-environment-variables.json Removes slackAlerting env var mapping.
services/apps/data_sink_worker/src/conf/index.ts Removes slackAlerting config accessor/types.
services/apps/data_sink_worker/config/custom-environment-variables.json Removes slackAlerting env var mapping.
services/apps/cron_service/src/main.ts Routes timeout alerts to CDP_CRITICAL_ALERTS.
services/apps/cron_service/src/jobs/queueMonitoring.job.ts Routes queue monitoring alerts to CDP_CRITICAL_ALERTS.
services/apps/cron_service/src/jobs/nangoMonitoring.job.ts Routes Nango monitoring alerts to CDP_INTEGRATIONS_ALERTS.
backend/src/conf/index.ts Removes SlackAlertingConfiguration usage/export.
backend/src/conf/configTypes.ts Removes SlackAlertingConfiguration type.
backend/src/api/public/v1/members/identities/verifyMemberIdentity.ts Routes audit/unmerge workflow errors to CDP_ALERTS.
backend/src/api/public/middlewares/errorHandler.ts Routes public API 500 alerts to CDP_ALERTS.
backend/src/api/apiResponseHandler.ts Routes generic API error alerts to CDP_ALERTS.
backend/config/default.json Removes default slackAlerting config section.
backend/config/custom-environment-variables.json Removes slackAlerting env var mapping.
backend/.env.dist.local Removes CROWD_SLACK_ALERTING_URL from env template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@themarolt themarolt closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants