Open and accept zero reserve channels

lightning-liquidity/tests/lsps2_integration_tests.rs

@@ -1514,10 +1514,12 @@ fn create_channel_with_manual_broadcast(
 		Event::OpenChannelRequest { temporary_channel_id, .. } => {
 			client_node
 				.node
-				.accept_inbound_channel_from_trusted_peer_0conf(
+				.accept_inbound_channel_from_trusted_peer(
 					&temporary_channel_id,
 					&service_node_id,
 					user_channel_id,
+					true,
+					false,
 					None,
 				)
 				.unwrap();

lightning-types/src/features.rs

@@ -168,7 +168,8 @@ mod sealed {
 			// Byte 7
 			Trampoline | SimpleClose | SpliceProduction,
 			// Byte 8 - 16
-			,,,,,,,,,
+			ZeroReserve,
+			,,,,,,,,
 			// Byte 17
 			AnchorZeroFeeCommitmentsStaging,
 			// Byte 18
@@ -197,7 +198,8 @@ mod sealed {
 			// Byte 7
 			Trampoline | SimpleClose | SpliceProduction,
 			// Byte 8 - 16
-			,,,,,,,,,
+			ZeroReserve,
+			,,,,,,,,
 			// Byte 17
 			AnchorZeroFeeCommitmentsStaging,
 			// Byte 18
@@ -696,6 +698,17 @@ mod sealed {
 		supports_splicing_production,
 		requires_splicing_production
 	);
+	define_feature!(
+		65,
+		ZeroReserve,
+		[InitContext, NodeContext],
+		"Feature flags for zero reserve.",
+		set_zero_reserve_optional,
+		set_zero_reserve_required,
+		clear_zero_reserve,
+		supports_zero_reserve,
+		requires_zero_reserve
+	);
 	// By default, allocate enough bytes to cover up to Splice. Update this as new features are
 	// added which we expect to appear commonly across contexts.
 	pub(super) const MIN_FEATURES_ALLOCATION_BYTES: usize = 63_usize.div_ceil(8);

lightning/src/events/mod.rs

@@ -1657,7 +1657,7 @@ pub enum Event {
 		/// Furthermore, note that if [`ChannelTypeFeatures::supports_zero_conf`] returns true on this type,
 		/// the resulting [`ChannelManager`] will not be readable by versions of LDK prior to
 		/// 0.0.107. Channels setting this type also need to get manually accepted via
-		/// [`crate::ln::channelmanager::ChannelManager::accept_inbound_channel_from_trusted_peer_0conf`],
+		/// [`crate::ln::channelmanager::ChannelManager::accept_inbound_channel_from_trusted_peer`],
 		/// or will be rejected otherwise.
 		///
 		/// [`ChannelManager`]: crate::ln::channelmanager::ChannelManager

lightning/src/ln/async_signer_tests.rs

@@ -78,10 +78,12 @@ fn do_test_open_channel(zero_conf: bool) {
 			Event::OpenChannelRequest { temporary_channel_id, .. } => {
 				nodes[1]
 					.node
-					.accept_inbound_channel_from_trusted_peer_0conf(
+					.accept_inbound_channel_from_trusted_peer(
 						temporary_channel_id,
 						&node_a_id,
 						0,
+						true,
+						false,
 						None,
 					)
 					.expect("Unable to accept inbound zero-conf channel");
@@ -387,10 +389,12 @@ fn do_test_funding_signed_0conf(signer_ops: Vec<SignerOp>) {
 			Event::OpenChannelRequest { temporary_channel_id, .. } => {
 				nodes[1]
 					.node
-					.accept_inbound_channel_from_trusted_peer_0conf(
+					.accept_inbound_channel_from_trusted_peer(
 						temporary_channel_id,
 						&node_a_id,
 						0,
+						true,
+						false,
 						None,
 					)
 					.expect("Unable to accept inbound zero-conf channel");

lightning/src/ln/chanmon_update_fail_tests.rs

@@ -3243,7 +3243,9 @@ fn do_test_outbound_reload_without_init_mon(use_0conf: bool) {
 			if use_0conf {
 				nodes[1]
 					.node
-					.accept_inbound_channel_from_trusted_peer_0conf(&chan_id, &node_a_id, 0, None)
+					.accept_inbound_channel_from_trusted_peer(
+						&chan_id, &node_a_id, 0, true, false, None,
+					)
 					.unwrap();
 			} else {
 				nodes[1].node.accept_inbound_channel(&chan_id, &node_a_id, 0, None).unwrap();
@@ -3353,7 +3355,9 @@ fn do_test_inbound_reload_without_init_mon(use_0conf: bool, lock_commitment: boo
 			if use_0conf {
 				nodes[1]
 					.node
-					.accept_inbound_channel_from_trusted_peer_0conf(&chan_id, &node_a_id, 0, None)
+					.accept_inbound_channel_from_trusted_peer(
+						&chan_id, &node_a_id, 0, true, false, None,
+					)
 					.unwrap();
 			} else {
 				nodes[1].node.accept_inbound_channel(&chan_id, &node_a_id, 0, None).unwrap();