Clarify find_route Documentation#4421
Open
StephenChi-hi wants to merge 1 commit intolightningdevkit:mainfrom
Open
Clarify find_route Documentation#4421StephenChi-hi wants to merge 1 commit intolightningdevkit:mainfrom
StephenChi-hi wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
==========================================
- Coverage 86.09% 86.06% -0.03%
==========================================
Files 156 156
Lines 103623 103623
Branches 103623 103623
==========================================
- Hits 89211 89187 -24
- Misses 11895 11919 +24
Partials 2517 2517
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation for the
find_routefunction inrouter.rsby:NetworkGraphandRouteParametersScoreLookUpfirst_hopsfor outbound channel selectionThese changes provide clearer guidance for users and developers on how route finding works and what to expect from the function.
Note
This is my part of my first set of open-source contribution as a developer. I appreciate the work behind this project and welcome any feedback or suggestions for improvement.