Skip to content

Rework ChannelManager::funding_transaction_signed #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpaulino wants to merge 1 commit into
base: main
Choose a base branch
from

Rework ChannelManager::funding_transaction_signed

135605f
Select commit
Loading
Failed to load commit list.
Open

Rework ChannelManager::funding_transaction_signed #4257

Rework ChannelManager::funding_transaction_signed
135605f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2025 in 0s

89.31% (-0.03%) compared to de384ff

View this Pull Request on Codecov

89.31% (-0.03%) compared to de384ff

Details

Codecov Report

❌ Patch coverage is 74.57143% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (de384ff) to head (135605f).

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 69.59% 39 Missing and 6 partials ⚠️
lightning/src/ln/channelmanager.rs 67.59% 29 Missing and 6 partials ⚠️
lightning/src/ln/splicing_tests.rs 90.78% 2 Missing and 5 partials ⚠️
lightning/src/events/mod.rs 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
- Coverage   89.33%   89.31%   -0.03%     
==========================================
  Files         180      180              
  Lines      139042   139030      -12     
  Branches   139042   139030      -12     
==========================================
- Hits       124219   124172      -47     
- Misses      12196    12217      +21     
- Partials     2627     2641      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov