Skip to content

RFC for PoC of bolt12 contacts formally known as a BLIP 42 #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenzopalazzo wants to merge 3 commits into
base: main
Choose a base branch
from

blip42: Add contact secret and payer offer support to invoice requests

40bd9e4
Select commit
Loading
Failed to load commit list.
Open

RFC for PoC of bolt12 contacts formally known as a BLIP 42 #4210

blip42: Add contact secret and payer offer support to invoice requests
40bd9e4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2025 in 0s

89.34% (-0.05%) compared to 62c5849

View this Pull Request on Codecov

89.34% (-0.05%) compared to 62c5849

Details

Codecov Report

❌ Patch coverage is 70.11952% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.34%. Comparing base (62c5849) to head (40bd9e4).

Files with missing lines Patch % Lines
lightning/src/offers/contacts.rs 75.36% 33 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs 33.33% 14 Missing and 2 partials ⚠️
lightning/src/offers/flow.rs 0.00% 15 Missing ⚠️
lightning/src/offers/invoice_request.rs 77.77% 6 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4210      +/-   ##
==========================================
- Coverage   89.38%   89.34%   -0.05%     
==========================================
  Files         180      181       +1     
  Lines      139834   140079     +245     
  Branches   139834   140079     +245     
==========================================
+ Hits       124985   125147     +162     
- Misses      12262    12335      +73     
- Partials     2587     2597      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov