Replace rand with getrandom and KeysManager entropy in non-test…#800
Open
TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
Open
Replace rand with getrandom and KeysManager entropy in non-test…#800TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
rand with getrandom and KeysManager entropy in non-test…#800TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
… code `rand` is basically just a way to wrap `getrandom` with a chacha stream plus a bag of unrelated random utilities. Given we already have a way to wrap `getrandom` with a chacha stream, there's no point in relying on `rand` for it, so we simply drop it here. Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
👋 Hi! Please choose at least one reviewer by assigning them on the right bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… code
randis basically just a way to wrapgetrandomwith a chacha stream plus a bag of unrelated random utilities. Given we already have a way to wrapgetrandomwith a chacha stream, there's no point in relying onrandfor it, so we simply drop it here.Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com