Update splice_in/splice_out to use new LDK two-phase funding API #794
Update splice_in/splice_out to use new LDK two-phase funding API #794jkczyz wants to merge 3 commits intolightningdevkit:mainfrom
splice_in/splice_out to use new LDK two-phase funding API #794Conversation
The LDK dependency bump introduced a new splicing API that separates negotiation from coin selection, letting LDK handle transaction construction internally rather than requiring manual UTXO selection and change address management. Generated with the assistance of AI (Claude Code). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Hi! I see this is a draft PR. |
| Ok(txid) | ||
| } | ||
|
|
||
| pub(crate) fn select_confirmed_utxos( |
There was a problem hiding this comment.
@tnull I'm wondering if we should implement CoinSelectionSource and use this rather than using LdkWallet for UTXO selection. It would prevent double persistence when we need a change output and the need for an explicit persist method after selection.
There was a problem hiding this comment.
Yeah, that seems preferable, if we have everything we need in the API by now?
| let txid = self.onchain_payment.send_to_address(&address, amt_sats, None)?; | ||
| return Ok(UnifiedPaymentResult::Onchain { txid }); | ||
| }, | ||
| PaymentMethod::Cashu(_) => todo!(), |
There was a problem hiding this comment.
Uh, let's not panic if someone includes Cashu instructions in the string above. Could just error and skip if this is hit.
| Ok(txid) | ||
| } | ||
|
|
||
| pub(crate) fn select_confirmed_utxos( |
There was a problem hiding this comment.
Yeah, that seems preferable, if we have everything we need in the API by now?
| async move { self.get_change_script_inner() } | ||
| } | ||
|
|
||
| fn get_prevtx<'a>( |
There was a problem hiding this comment.
Seems this is not used anywhere? Btw, also note related changes we recently landed in 788055f
3 participants
The LDK dependency bump introduced a new splicing API that separates negotiation from coin selection, letting LDK handle transaction construction internally rather than requiring manual UTXO selection and change address management.