Merged
Conversation
It appears to have been inadvertently downgraded in baf90c7
Member
|
Thank you @nbelakovski . Should we worry about the failures of the builds in the CI? If the failures are independent of the current PR, I will merge it. |
Contributor
Author
|
It looks like the cmake failures are all with the intel compiler and are unrelated to pybind11. The Python failures are also unrelated to pybind11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears to have been inadvertently downgraded in baf90c7
@zaikunzhang Please be sure to run
git submodule updatewhen you see(new commits)in the status and you're not working on other submodule changes.