Fix issue with :not() selector in nested replacement (issue #1680)#4375
Closed
Keerthanakoduri wants to merge 1 commit intoless:masterfrom
Closed
Fix issue with :not() selector in nested replacement (issue #1680)#4375Keerthanakoduri wants to merge 1 commit intoless:masterfrom
Keerthanakoduri wants to merge 1 commit intoless:masterfrom
Conversation
dosubot
bot
added
the
size:M
Member
|
Closing - this PR adds +12,114 lines for a :not() fix, which suggests generated/build files were accidentally included. The fix itself may be valid but needs to be resubmitted cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1680 — extended all replacement logic in nested selectors (:not() and similar cases) inside Less.js.
Modified files:
Why:
Previously, the :not() selector handling inside nested replacements caused incorrect behavior.
This PR improves the selector logic to handle nested cases correctly, ensuring accurate CSS output.
Checklist:
This change addresses bug #1680 as described in the issue tracker.
Please review and let me know if any additional test coverage or documentation is required.