Review "advanced alignment mode" commits for workable contributions#95
Draft
alerque wants to merge 3 commits intoledger:masterfrom
Draft
Review "advanced alignment mode" commits for workable contributions#95alerque wants to merge 3 commits intoledger:masterfrom
alerque wants to merge 3 commits intoledger:masterfrom
Conversation
In advance alignment mode, it behaves similar to emacs alignment. Activated by setting g:ledger_align_advance = 1
|
Hey @alerque. Sorry for the super long delay in replying. I am more than happy for this to get merged in and fixed up for other commodities. Do you need me to open a PR or can this get converted into one? |
Member
Author
|
Hey no worries on the timing. This PR is against your master branch so anything you do there will show up here. This would probably require rebasing your master branch to be productive. If you'd rather work on a new branch taken from the current master and cherry pick or merge into that you can submit that as a separate PR. Either way let me know if there is anything I can do to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of commits from @dedmons has some interesting ideas, adding here as a PR to consider for possible inclusion and/or reworking.