Skip to content

Fix copy path needing one more /contentcuration#5756

Merged
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:post-uv-frontend-serve
Mar 12, 2026
Merged

Fix copy path needing one more /contentcuration#5756
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:post-uv-frontend-serve

Conversation

@bjester
Copy link
Member

@bjester bjester commented Mar 12, 2026

Summary

  • The refactored Dockerfile copied the wrong directory; both of these exist
    • /contentcuration/contentcuration/static -- referenced by old cruft, misled me, but it's where collectstatic puts all static files eventually
    • /contentcuration/contentcuration/contentcuration/static -- where the frontend assets really live
  • We should probably rename the root directory something else like /app or /src to reduce this confusion, although we would need to coordinate that with infra since k8s configs reference this
  • The ENTRYPOINT was changed to CMD to facilitate easier inspection, allowing you to launch /bin/bash in it; this should not affect k8s
  • The exposed port was changed to align with make altprodserver; k8s uses the same port
  • Confusing and unneeded cruft was removed
  • Added docker-compose YAML for testing build and startup of the production image

References

Fixes #5754

Reviewer guidance

  1. I started up services make dcservicesup
  2. I edited the docker-compose.prod.yml to point to the network created by make dcservicesup, e.g.:
networks:
  default:
    name: studio_post-uv-frontend-serve_default
    external: true
  1. I ran docker compose -f docker-compose.prod.yml up
  2. I accessed http://localhost:8080/
  3. While it still wasn't loading all resources (I think this is existing due to config differences), I confirmed that the frontend assets were copied and that it didn't fail to find the serviceWorker.js like the Sentry error

AI usage

I asked AI to help debug it. Ultimately, it didn't help.

@bjester bjester force-pushed the post-uv-frontend-serve branch from 0954ba6 to c101d70 Compare March 12, 2026 18:17
@rtibbles rtibbles merged commit f45d9a6 into learningequality:unstable Mar 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: expected str, bytes or os.PathLike object, not NoneType

2 participants