Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 26, 2025


See issue #17033.

Moved from #28743.

Open in Gitpod

@vihdzp vihdzp added awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. t-order Order theory t-set-theory Set theory labels Dec 26, 2025
@github-actions
Copy link

github-actions bot commented Dec 26, 2025

PR summary 74bdd8deff

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsFundamentalSequence.of_isNormal
+ apply_le_nfp
+ apply_lt_nfp
+ apply_omega0_of_isNormal
+ cof_eq_of_isNormal
+ cof_le_of_isNormal
+ deriv_fp
+ fp_iff_deriv
+ iSup_add_natCast
+ iSup_mul_natCast
+ iSup_pow_natCast
+ isNormal_veblenWith_zero
+ le_iff_deriv
+ mem_range_deriv
+ monotone
+ nfp_fp
+ nfp_le_apply
- IsNormal.mem_range_deriv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@vihdzp vihdzp mentioned this pull request Dec 26, 2025
12 tasks
@vihdzp vihdzp requested a review from YaelDillies December 26, 2025 01:13
@github-actions github-actions bot removed the awaiting-CI This PR doesn't pass CI yet. This label is automatically removed once it does. label Dec 26, 2025
@YaelDillies
Copy link
Collaborator

Thanks!

maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 26, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 26, 2025

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 26, 2025
@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 26, 2025

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: deprecate Ordinal.IsNormal for Order.IsNormal [Merged by Bors] - refactor: deprecate Ordinal.IsNormal for Order.IsNormal Dec 26, 2025
@mathlib-bors mathlib-bors bot closed this Dec 26, 2025
@vihdzp vihdzp deleted the normal branch December 26, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory t-set-theory Set theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants