Skip to content

Conversation

@aldas
Copy link
Contributor

@aldas aldas commented Jan 25, 2026

Context: json should not send status code before serialization is complete

Relates to #2866 (comment)

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.02%. Comparing base (f24aaff) to head (fbffb62).
⚠️ Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
response.go 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2877      +/-   ##
==========================================
- Coverage   93.25%   93.02%   -0.23%     
==========================================
  Files          39       43       +4     
  Lines        4652     4456     -196     
==========================================
- Hits         4338     4145     -193     
+ Misses        218      194      -24     
- Partials       96      117      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aldas aldas force-pushed the v5_json_status_code1 branch from ad8355d to 8e41156 Compare January 28, 2026 08:51
@aldas aldas merged commit 1f3ef29 into labstack:master Jan 28, 2026
6 of 7 checks passed
@aldas aldas deleted the v5_json_status_code1 branch January 28, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant