Conversation
…rtifact-actions chore(deps): update github artifact actions (major)
…monorepo chore(deps): update dependency workbox-build to v7
|
Warning Rate limit exceeded@ThomasJejkal has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughBumped CI action versions and Node runtime (20→24) in workflows, updated root and package-specific dependencies (lerna, workbox-build, vite, Storybook packages), and changed TypeScript module resolution to "bundler" in the stencil-library tsconfig. No API or exported signatures changed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chore(deps): update dependency node to v24
…-pages-artifact-4.x chore(deps): update actions/upload-pages-artifact action to v4
…node-6.x chore(deps): update actions/setup-node action to v6
…ut-6.x chore(deps): update actions/checkout action to v6
…norepo chore(deps): update dependency lerna to v9
fix(deps): update dependency vite to v7.3.1
…k-monorepo chore(deps): update storybook monorepo to v10 (major)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @package.json:
- Around line 8-16: CI is testing Node 18 but package.json upgrades (lerna v9
and vite 7.3.1) require Node ≥20.19 / ≥22.12 / ≥24, so update your workflow to
remove Node 18 from the test matrix (or pin to a supported Node version),
regenerate the lockfile by running npm install, and run npx lerna repair to
update lerna.json for v9 compatibility; also confirm workbox-build upgrade needs
no config changes.
🧹 Nitpick comments (2)
.github/workflows/npm-ci.yml (1)
20-23: Add npm caching to speed up matrix builds in monorepo.With the root
package-lock.json, addcache: 'npm'to the setup-node step to cache dependencies across matrix jobs:Recommended npm caching
- uses: actions/setup-node@v6 with: node-version: ${{ matrix.node }} + cache: 'npm'This will improve CI performance by avoiding repeated
npm cidownloads across the four Node versions (18, 20, 22, 24). Theactions/setup-node@v6automatically detects the rootpackage-lock.jsonand manages the cache accordingly in your monorepo setup with lerna..github/workflows/deploy-storybook.yml (1)
15-18: Pin GitHub Actions by SHA for supply-chain hardening; major version breaking changes confirmed.actions/checkout@v6 changed persist-credentials behavior (now uses separate credential file instead of .git/config), actions/setup-node@v6 removed the
always-authinput, and actions/upload-pages-artifact@v4 excludes dotfiles by default—though none of these likely affect this workflow. The suggestedcache: 'npm'parameter is valid and will enable npm caching in setup-node@v6 (it auto-caches npm by default but can be made explicit). Consider switching from tag pinning (v6, v4) to commit SHA pinning for better supply-chain hardening across all three actions.Proposed hardening + caching
- - uses: actions/checkout@v6 - - uses: actions/setup-node@v6 + - uses: actions/checkout@v6 + - uses: actions/setup-node@v6 with: node-version: 24 + cache: 'npm'Consider pinning actions to commit SHAs instead of mutable tags (e.g.,
actions/checkout@{SHA}) for enhanced supply-chain security.Also applies to: 28-30 (actions/upload-pages-artifact@v4)
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
.github/workflows/deploy-storybook.yml.github/workflows/npm-ci.yml.github/workflows/real-npm-publish.ymlpackage.json
🔇 Additional comments (2)
package.json (1)
4-4: Confirm rootversionat line 4 matches the intended release version.The root
package.jsonshows"version": "0.1.0"but the PR appears to targetv0.1.1. If this repo uses fixed-versioning with Lerna (rather than independent mode), the root version must be updated to0.1.1. Additionally, the major dependency bumps (lerna ^9.0.0, workbox-build ^7.0.0) should be verified for compatibility, and confirm thatpackage-lock.jsonor equivalent lockfile has been updated accordingly..github/workflows/real-npm-publish.yml (1)
21-25: Actions version upgrades are backwards compatible with existing workflow.Verified that
upload-artifact@v6anddownload-artifact@v7preservenameandpathsemantics, andcheckout@v6/setup-node@v6do not break lerna publish. The workflow does not use the removedalways-authinput.Minor note: If using self-hosted runners, ensure runner version ≥ v2.327.1 for Node 24 support; GitHub-hosted runners are already current.
Regarding SHA pinning: this is an optional supply-chain hardening best practice but not required for these upgrades to function safely.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @packages/stencil-library/package.json:
- Around line 61-64: This upgrade to Storybook 10 in package.json requires
migrating to ESM config and ensuring Node compatibility: run npx
storybook@latest upgrade to apply automigrations, convert all .storybook/*.js|ts
config files to ESM syntax (use export default and import rather than
require/module.exports), verify you are running Node >=20.19 (or 22.12+) and add
an "engines": {"node": ">=20.19.0"} entry in package.json to enforce it, and
confirm the Storybook packages listed ("@storybook/addon-docs",
"@storybook/addon-links", "@storybook/web-components",
"@storybook/web-components-vite") are used with ESM-compatible imports and build
tooling.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
packages/stencil-library/package.jsonpackages/stencil-library/tsconfig.json
🔇 Additional comments (1)
packages/stencil-library/tsconfig.json (1)
13-13: The moduleResolution change to "bundler" is compatible and recommended.TypeScript 5.8.3+ and Stencil 4.41.0 both support this configuration. Bundler mode is the recommended approach for modern Stencil projects using TypeScript 5+. No further verification needed—this change aligns with current best practices.
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.