-
Notifications
You must be signed in to change notification settings - Fork 24
docs(management): update examples and README for corrected users endpoints #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated ManagementClient user-method signatures to use Changes
Sequence Diagram(s)sequenceDiagram
participant App as Example / App
participant SDK as ManagementClient
participant API as Management API
Note left of App `#DDEBF7`: Example calls SDK
App->>SDK: get_user(id= "user_id")
Note right of SDK `#F6F8FA`: SDK maps to GET /user?id=...
SDK->>API: GET /user?id=user_id
API-->>SDK: 200 OK + user JSON
SDK-->>App: user JSON
rect rgba(220,235,255,0.6)
Note over App,API: Create user flow uses nested profile payload
App->>SDK: create_user(profile={given_name, family_name}, email=...)
SDK->>API: POST /users\nbody: { profile: { given_name, family_name }, ... }
API-->>SDK: 201 Created
SDK-->>App: created user
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-21T04:46:50.368ZApplied to files:
🪛 markdownlint-cli2 (0.18.1)kinde_sdk/management/README.md67-67: Code block style (MD046, code-block-style) 🔇 Additional comments (2)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README_management_client.md (2)
89-93: Standardize method list parameter formattingFor consistency with other entries (e.g.,
get_role(role_id)), preferget_user(id),update_user(id, **data),delete_user(id)rather thanid=user_idin the methods list.-- `get_user(id=user_id)` - Get a specific user +- `get_user(id)` - Get a specific user -- `update_user(id=user_id, **data)` - Update a user +- `update_user(id, **data)` - Update a user -- `delete_user(id=user_id)` - Delete a user +- `delete_user(id)` - Delete a user
147-150: Create user payload update looks good; add a brief migration noteThe
profile.given_name/family_namestructure is clear. Consider a small “Migration” callout showing the old vs new payload to help users adjust quickly.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README_management_client.md(3 hunks)examples/management_client_example.py(1 hunks)kinde_sdk/management/README.md(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-21T04:46:50.368Z
Learnt from: KomanRudden
PR: kinde-oss/kinde-python-sdk#101
File: kinde_sdk/auth/permissions.py:6-7
Timestamp: 2025-08-21T04:46:50.368Z
Learning: The kinde_sdk has both frontend and management API modules. The frontend permissions_api.py exists at kinde_sdk/frontend/api/permissions_api.py and contains PermissionsApi class. Using the management API instead of the frontend API for user permissions would be incorrect.
Applied to files:
kinde_sdk/management/README.md
🔇 Additional comments (4)
examples/management_client_example.py (1)
183-183: Switch to keyword id looks correctUsing
client.get_user(id=user_id)aligns with the updated single-user endpoints. LGTM.kinde_sdk/management/README.md (2)
10-10: Filename reference is accurate
management_client.pymatches the module path used elsewhere. LGTM.
145-145: Error handling example aligns with new signature
management.get_user(id=user_id)is consistent with the API note above. LGTM.README_management_client.md (1)
56-56: Quick Start uses the new id keyword correctly
get_user(id="user_id")reflects the updated API. LGTM.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Explain your changes
README_management_client.md:id=instead of positionaluser_idin examples.profileandidentitiesstructure.management_client_example.py:get_usernow useid=<user_id>.management/README.md:get_userusage to useid=user_id.Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.