Skip to content

fix: ARM64 build fails due to x86-only CRC32 intrinsics #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kernelwernel merged 1 commit into from
Jan 6, 2026
Merged

fix: ARM64 build fails due to x86-only CRC32 intrinsics #597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/vmaware.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,12 +1935,19 @@ struct VM {

// For strings shorter than 16-32 bytes, the overhead of setting up the _mm_crc32_u64 (or 32) loop, then checking length, handling the tail bytes, and finally handling alignment,
// will always make it slower or equal to a simple unrolled u8 loop, and not every cpu model fits in u32/u64
#if (CLANG || GCC)
#if (x86 && (CLANG || GCC))
__attribute__((__target__("crc32")))
#endif
static u32 crc32_hw(u32 crc, char data) {

#if (x86)
return _mm_crc32_u8(crc, static_cast<u8>(data));
#else
// Fallback for non-x86: use software CRC32-C
crc ^= static_cast<u8>(data);
for (int i = 0; i < 8; ++i)
crc = (crc >> 1) ^ ((crc & 1) ? 0x82F63B78u : 0);
return crc;
#endif
}

using hashfc = u32(*)(u32, char);
Expand Down Expand Up @@ -9244,7 +9251,7 @@ struct VM {
* @implements VM::BOOT_LOGO
*/
[[nodiscard]] static bool boot_logo()
#if (CLANG || GCC)
#if (x86 && (CLANG || GCC))
__attribute__((__target__("crc32")))
#endif
{
Expand Down
Loading