fix: add guard in clPhotoswipe and correct Mailchimp URL#26
Open
raja2576 wants to merge 1 commit intokeploy:mainfrom
Open
fix: add guard in clPhotoswipe and correct Mailchimp URL#26raja2576 wants to merge 1 commit intokeploy:mainfrom
raja2576 wants to merge 1 commit intokeploy:mainfrom
Conversation
Signed-off-by: raja2576 <164044997+raja2576@users.noreply.github.com>
b277893 to
c22f234
Compare
|
Hey @raja2576, Thank you for raising the pr. Our team will soon review the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the
writers-programfrontend JavaScript code:data-sizeis missing from thumbnail links. This prevents.split()from throwing runtime errors.postURL with the properpost-jsonformat required for Mailchimp’s AJAX submission to work correctly.Changes Made
clPhotoswipefunction to skip items with undefineddata-sizemailChimpURLin the config to usepost-json?...&c=?Why This is Important
data-sizeis not defined on a gallery itemTesting
Type of Contribution