fix: resolve internal markdown link routing (#2267)#2268
Open
h30s wants to merge 1 commit intojson-schema-org:mainfrom
Open
fix: resolve internal markdown link routing (#2267)#2268h30s wants to merge 1 commit intojson-schema-org:mainfrom
h30s wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 663 663
Branches 205 205
=========================================
Hits 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@vtushar06 Ready for review. Please take a look whenever you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
StyledMarkdownBlock#2267Screenshots/videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
Internal Markdown links in
StyledMarkdownBlockwere incorrectly forced to open in new tabs (target="_blank") and routed to the homepage (/), which broke SPA transitions and Next.js prefetching.This PR updates the routing logic to properly recognize internal paths (starting with
/or#) and uses the Next.js<Link>component correctly withouttarget="_blank", restoring standard client-side navigation.Does this PR introduce a breaking change?
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.