Added test cases for JsonFormatter class and refactored the code base #1008
Open
vaibhavramchandani wants to merge 12 commits intojson-path:masterfrom
Open
Added test cases for JsonFormatter class and refactored the code base #1008vaibhavramchandani wants to merge 12 commits intojson-path:masterfrom
vaibhavramchandani wants to merge 12 commits intojson-path:masterfrom
Conversation
added 12 commits
March 2, 2024 13:06
This class is in com.jayway.jsonpath.internal package.Add cases to cover the following: -Simple Json Object, Json Object Array -Json With Escaped Characters,Json Object with Escaped Characters
This class is in com.jayway.jsonpath.internal package.Add cases to cover the following: -Simple Json Object, Json Object Array -Json With Escaped Characters,Json Object with Escaped Characters
…PathCompiler.java
…ional association refactor technique
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added test cases in the JsonFormatter Class increasing the overall test code.
Additionally, I have refactored the codebase, working on both implementation smells and design smells. For implementation smells, I used the following methods:
Extract method
Introduce explaining variable
Decompose conditional
For design smells, I used the following techniques to refactor the code:
Move method/field
Extract class
Change bidirectional association to unidirectional association
Please let me know if there's anything else you'd like to modify or if you need further assistance!