Merged
Conversation
4568bdb to
1fc997b
Compare
- Update util.go: 1.64.1 -> 1.87.0 (nixpkgs version for devbox services) - Update flakeref test: v0.40.2 -> v1.87.0 (GitHub tag) - Remove unused processComposeTargetVersion constant from devbox.go - Update postgresql plugin to use foreground mode instead of daemon mode (required for compatibility with process-compose 1.75.0+) The postgresql plugin change: - Changed from `pg_ctl start` with `is_daemon: true` to running `postgres` directly with `is_daemon: false` - This is the recommended pattern for process managers and fixes compatibility with newer process-compose versions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4ffa73b to
307478e
Compare
Collaborator
Author
|
This PR also updates our postgresql plugin for compatibility with the new version of process compose |
savil
reviewed
Feb 5, 2026
Comment on lines
-5
to
+7
| command: "pg_ctl start -o \"-k '$PGHOST' ${PGPORT:+-p '$PGPORT'}\"" | ||
| is_daemon: true | ||
| shutdown: | ||
| command: "sh -c 'exec postgres -k \"$PGHOST\" -p \"${PGPORT:-5432}\"'" | ||
| is_daemon: false | ||
| shutdown: |
Collaborator
Author
There was a problem hiding this comment.
It looks like process-compose fixed a bug with how it manages daemons. As a result our postgresql plugin now restarts continuously (because it's not actually forking and exiting like a daemon) and it never exposes a port.
So we just stop treating it like a daemon and run it in foreground mode. it gets it's own shell anyways, so it doesn't interfere with the user's devbox shell + it's easier to manage
savil
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processComposeTargetVersionconstantTest plan
go test ./...)🤖 Generated with Claude Code