Properly disable clicks in inactive views behind popups#5313
Merged
stefanhaller merged 2 commits intomasterfrom Mar 8, 2026
Merged
Properly disable clicks in inactive views behind popups#5313stefanhaller merged 2 commits intomasterfrom
stefanhaller merged 2 commits intomasterfrom
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
8a8dc91 to
af5549f
Compare
… panels This fixes two problems: - if the previously focused view (behind the panel) was a list view, it would look like the click would select a different row, because gocui would still set the view's cursor position, which is used to draw the highlighted row - it was still possible to click on tab headers, and this would dismiss the panel
af5549f to
b955002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did already have code to prevent clicks in inactive views behind a popup, but it wasn't good enough. This PR fixes two problems:
Fixes #5256.