feat: Build and export library in CommonJS format#1
Merged
jcubic merged 4 commits intoisomorphic-git:mainfrom Feb 9, 2025
Merged
feat: Build and export library in CommonJS format#1jcubic merged 4 commits intoisomorphic-git:mainfrom
jcubic merged 4 commits intoisomorphic-git:mainfrom
Conversation
7589d05 to
b662656
Compare
Member
|
There are some errors from npm install in GitHub workflow. |
Author
|
It looks like |
Member
|
Is it ready to publish to NPM? |
Author
|
Yes, I think after the README is updated (#2) it's ready to be published. I did a manual test locally using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
buildscript to compile the library to CommonJS format using a minimal Rollup setup; and anexportsproperty inpackage.json(here) so the published NPM package can be consumed in both CJS and ESM formats.This is related to:
path-browserifyconverted to ES Module with individually exported methods isomorphic-git#2035The build/test pipeline in the above PR currently fails due to the step
build.docsusing CommonJS require.Using the GitHub URL to add
@isomorphic-git/path-browserifyas a dependency will only work if the repo includes the builtindex.cjs.Next steps:
index.cjsand exclude in.gitignore@isomorphic-git/path-browserifyto NPMisomorphic-git/isomorphic-git#2035to use the published NPM package instead of GitHub URL. Confirm the build/test pipeline succeeds.@jcubic