Skip to content

Better OTel and use Pull Diagnostics for tests#1341

Closed
TheAngryByrd wants to merge 3 commits intoionide:mainfrom
TheAngryByrd:better-otel-tests
Closed

Better OTel and use Pull Diagnostics for tests#1341
TheAngryByrd wants to merge 3 commits intoionide:mainfrom
TheAngryByrd:better-otel-tests

Conversation

@TheAngryByrd
Copy link
Member

No description provided.

jaeger:
profiles:
- jaeger
image: jaegertracing/all-in-one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG travesty - not using the Aspire Dashboard? 😱


let! (server, events) = serverInitialize path analyzerEnabledConfig state
let scriptPath = Path.Combine(path, "Script.fsx")
do! Async.Sleep(TimeSpan.FromSeconds 5.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh it's very promising to remove the random sleeps

@github-actions

This comment has been minimized.

@TheAngryByrd
Copy link
Member Author

/repo-assist rebase against main and fix formatting.

Remaining work would be:

  • Convert back to dotnet test but still have it possible to configure the OTel correctly for the test run
  • Output failed test's traces
  • Upload these failed traces during CI so inspection could be done to diagnose issues
  • Fix any failing tests

@github-actions
Copy link
Contributor

Issue created: #1480

Generated by Repo Assist

@github-actions
Copy link
Contributor

🤖 Repo Assist here.

I've rebased your PR onto main, fixed the formatting issues, and implemented the remaining work you listed:

What was done:

  • ✅ Rebased all 3 commits cleanly onto current main
  • ✅ Fixed fantomas formatting in FsOpenTelemetry.fs and AdaptiveServerState.fsi
  • Converted back to dotnet test — the CI workflow now uses dotnet test with AltCover, GitHubActions logger, and --blame-hang --blame-hang-timeout 1m again
  • OTel still works — moved the trace provider initialisation to module level (a do block in Program.fs) so it fires before the VSTest host discovers tests, making it compatible with both dotnet run and dotnet test
  • Failed traces are outputFailedTestOtlpFileExportProcessor still exports OTLP JSON files for failed tests
  • Failed traces uploaded in CI via actions/upload-artifact on failure
  • ✅ Local dev: uses the standard OTEL_EXPORTER_OTLP_ENDPOINT env var instead of hard-coded localhost:4317

The new PR is ready for review. The full test suite still needs to run in CI to validate there are no test failures introduced by the rebase.

Note on failing tests: I wasn't able to run the full integration test suite locally (it requires a full LSP server spin-up), so any pre-existing test failures would show up in CI on the new PR. Happy to investigate specific failures once CI reports them.

Generated by Repo Assist for issue #1341

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@afb00b92a9514fee9a14c583f059a03d05738f70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants