docs(modal): add playgrounds for sheet and card modal drag events#4415
docs(modal): add playgrounds for sheet and card modal drag events#4415thetaPC wants to merge 18 commits intofeature-8.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
left a comment
There was a problem hiding this comment.
Just a couple things that more or less depend on what you do with the framework PR
brandyscarney
left a comment
There was a problem hiding this comment.
Looking good but requesting some changes!
docs/api/modal.md
Outdated
|
|
||
| The `ionDragEnd` event is emitted when the user completes the dragging gesture by releasing the modal. Like the move event, it includes the final `ModalDragEventDetail` [object](#modaldrageventdetail). This event is commonly used to finalize state changes once the modal has come to a rest. For example, you might use the `predictedBreakpoint` property to determine which content to load or to update the application's routing state once the user has finished swiping the sheet to a specific height. | ||
|
|
||
| <SheetDragEvents /> |
There was a problem hiding this comment.
When we name the playground folders can we match the event name like range:
- ion-change-event
- ion-knob-move-event
or reorder:
- reorder-move-event
- reorder-start-end-events
There was a problem hiding this comment.
There seem to be some inconsistencies with the opacity based on where you stop and start the drag. When I drag it to the 0.75 breakpoint then press to start the drag again it gets really dark:
modal-drag-events.mov
I would expect it to start off at the opacity it is on and then get darker as I drag up. This seems to happen on all of the StackBlitz examples.
There was a problem hiding this comment.
Should we include console logs like Range & Reorder do? We don't have to do it for each drag event but maybe like the drag start, drag end, and when the breakpoint changes during move? Relevant code:
ionic-docs/static/usage/v8/range/ion-change-event/demo.html
Lines 29 to 35 in 1ff280d
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Issue URL: internal
What is the current behavior?
The sheet and card modal can be dragged to view content. However, there are no events that determine when drag has started or ended.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
8.7.17-dev.11772118942.181221d4